test: Update navigation tests with more pages and assertions #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kodiakhq merged 1 commit into main from drew/improve-navigation-e2e

Dec 30, 2025

Merged

test: Update navigation tests with more pages and assertions #1538

kodiakhq merged 1 commit into main from drew/improve-navigation-e2e

Dec 30, 2025

+74 −13

Conversation

@pulpdrew

Copy link

Contributor

@pulpdrew pulpdrew commented Dec 30, 2025

Summary

This PR updates the existing E2E navigation test so that it

Actually navigates to each page and asserts that the page loads
Checks additional pages which were not checked before (preset dashboards, service map)

@pulpdrew


 test: Update navigation tests with more pages and assertions

87525a2

@changeset-bot

Copy link

changeset-bot bot commented Dec 30, 2025

⚠️ No Changeset found

Latest commit: 87525a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

Copy link

vercel bot commented Dec 30, 2025 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
hyperdx-v2-oss-app	Ready Ready	Preview, Comment	Dec 30, 2025 7:33pm

@claude

Copy link

claude bot commented Dec 30, 2025

Code Review

❌ Test ID mismatch: Test expects incorrect auto-generated test IDs from AppNavLink component

AppNavLink (AppNav.components.tsx:295) auto-generates test IDs as nav-link-{href}
Test expects nav-link-clickhouse-dashboard but AppNavLink generates nav-link-clickhouse
Test expects nav-link-services-dashboard but AppNavLink generates nav-link-services
Test expects nav-link-k8s-dashboard but component generates nav-link-kubernetes
Fix: Update test to use correct auto-generated IDs or manually override test IDs in AppNav.tsx

⚠️ Inconsistent test ID pattern: Mixing auto-generated and manual test IDs

Some links use auto-generated IDs (service-map), others manually override (clickhouse-dashboard, services-dashboard, k8s-dashboard)
Fix: Either use all auto-generated IDs consistently OR add manual overrides to all nested nav links for consistency