-
Notifications
You must be signed in to change notification settings - Fork 343
Add getting started components #1517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...tion This commit introduces a new Getting Started component, complete with a stepper interface for guiding users through data ingestion and configuration. It includes a dedicated SCSS module for styling and a Storybook setup for showcasing various states of the component. The component supports displaying system status and allows users to copy the endpoint and API key.
...pport This update improves the Getting Started component by adding a stepper interface for guiding users through data ingestion and configuration. It introduces new styles for completed steps and integrates mock data for sources and connections in Storybook. The component now supports callbacks for user actions, enhancing interactivity and usability.
...u and SourceForm This commit modifies the button styles in the ConfirmDeleteMenu to use a light variant with a red color for better visibility. Additionally, it enhances the SourceForm layout by replacing the previous button structure with a more streamlined design, incorporating a Flex container for better alignment and spacing. The GettingStarted component also sees updates with new icons and improved button styles for a more cohesive user experience.
...ariants This commit introduces a new ActionIcon component with various size and variant examples in Storybook. Additionally, it enhances the Button component stories by adding new variants (primary, secondary, danger) and sizes, improving the overall showcase of button functionalities. The GettingStarted component's SCSS has also been cleaned up for better maintainability.
🦋 Changeset detectedLatest commit: 3e51f3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review
✅ No critical issues found.
The PR successfully implements a well-structured onboarding wizard with proper separation of concerns. The code follows project patterns and demonstrates good practices:
Highlights:
- Memory leak prevention in CredentialsTable with proper timeout cleanup (lines 27-36)
- Good use of custom Mantine variants (primary, secondary, danger) as documented
- Proper refactoring of SourcesList/SourceForm into reusable components with configurable props
- Consistent error handling and loading states in SourcesList
Minor observations (non-blocking):
- ErrorBoundary color change from orange to red is intentional and improves consistency
- Custom button variants properly documented in code_style.md
- Storybook stories are comprehensive and well-organized
Nice work on the implementation! 🚀
Contributor
E2E Test Results✅ All tests passed • 51 passed • 4 skipped • 688s
Tests ran across 4 shards in parallel. |
... SourcesList components for consistency
... and update Storybook preview to include fontFamily in ThemeWrapper
...ck for better performance
...mproved styling consistency
...s with error handling and loading states
...ed structure and functionality
...nts and refactor ConfirmDeleteMenu button variant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Implements a new "Getting Started" onboarding wizard to guide users through initial setup, including data ingestion and source configuration.
Changes
New Components
Refactored Components
components/Sources/for reuse across GettingStarted and TeamPagevariant,withCard,withBorder,showEmptyStatecomponents/Sources/folder with updated import pathsTheme Enhancements
primary,secondary,dangerOther Improvements
agent_docs/code_style.mdwith custom Mantine variants documentationScreenshots
Add screenshots of the GettingStarted component in Step 1 and Step 2
Testing
Getting started
imageButton
imageActionButton
image