This repository was archived by the owner on Nov 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 112
Open
Conversation
eyecatchup
added a commit
to eyecatchup/CAAT
that referenced
this pull request
Mar 13, 2014
Merge patches hyperandroid#160, hyperandroid#161, hyperandroid#162 and hyperandroid#163 into patch-164 branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using sprite maps with CAAT: on startup, we load a 2048x2048px map with the preloader and initialize it using the initializeFromMap function. Works like a charm.
In order to use the sprites of the map, we would need to do something along these lines:
var sprite = spriteMap.getRef().setSpriteIndex('name');
var actor = new CAAT.Actor();
actor.setBackgroundImage(sprite, false);
actor.setSize(sprite.getWidth(), sprite.getHeight());
This is obviously quite uncomfortable. Preferably, one would use something like this:
var actor = new CAAT.Actor();
actor.setBackgroundImage(spriteMap.setSpriteIndex('name'), true);
Unfortunately, this does not work because setBackgroundImage calls getRef(), which does not copy the spriteIndex of the image.
We fixed this by copying the spriteIndex in getRef() as well. We can now use the spritemap as describe above, which is really efficient.