Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add AttentionMixin to WanVACETransformer3DModel #12268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DN6 merged 3 commits into huggingface:main from J4BEZ:WanVACE_Attention
Sep 3, 2025

Conversation

Copy link
Contributor

@J4BEZ J4BEZ commented Sep 2, 2025

What does this PR do?

This PR enables WanVACETransformer3DModel to use methods from AttentionMixin, such as set_attn_processor().
#12186

I would like to express my sincere gratitude to the Hugging Face team for your continuous efforts, which make it easier and faster for researchers and developers to enjoy deep learning every day.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

At your convenience, I would be grateful if you could review this, @DN6 

to enable methods like `set_attn_processor()`.
Copy link
Contributor

@tolgacangoz tolgacangoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @J4BEZ, thanks for adding this. Also importing it?

J4BEZ reacted with heart emoji
Copy link
Contributor Author

J4BEZ commented Sep 3, 2025

@tolgacangoz Yes, absolutely! Importing AttentionMixin is essential.
I sincerely appreciate you catching this — it was a close call.

Wishing you a peaceful day and good health.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@tolgacangoz tolgacangoz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think it seems OK now.

J4BEZ reacted with heart emoji
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

J4BEZ reacted with heart emoji
@DN6 DN6 merged commit 6682956 into huggingface:main Sep 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DN6 DN6 DN6 approved these changes

+1 more reviewer

@tolgacangoz tolgacangoz tolgacangoz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /