Minor modification to support DC-AE-turbo #12169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

a-r-r-o-w merged 3 commits into huggingface:main from chenjy2003:DC-AE-turbo

Aug 18, 2025

Merged

Minor modification to support DC-AE-turbo #12169

a-r-r-o-w merged 3 commits into huggingface:main from chenjy2003:DC-AE-turbo

Aug 18, 2025

Conversation

chenjy2003

Copy link

Contributor

@chenjy2003 chenjy2003 commented Aug 18, 2025

What does this PR do?

This PR will add minor modification to support DC-AE-turbo into the diffusers lib. dc-ae-turbo-f32c32-sana-1.1 has the same encoder as dc-ae-f32c32-sana-1.0 and a lightweight decoder to accelerate decoding.

Could you please have a look? Thanks! @sayakpaul @yiyixuxu
Cc: @lawrence-cj

chenjy2003 added 2 commits

August 18, 2025 10:04

@chenjy2003


 minor modification to support dc-ae-turbo

c6ad097

@chenjy2003


 minor

58592bd

@sayakpaul sayakpaul requested a review from a-r-r-o-w

August 18, 2025 02:44

@sayakpaul


 Merge branch 'main' into DC-AE-turbo

da65bbc

a-r-r-o-w

a-r-r-o-w approved these changes

Aug 18, 2025

View reviewed changes

Copy link

Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chenjy2003!

src/diffusers/models/autoencoders/autoencoder_dc.py

downsample_block_type: str = "pixel_unshuffle",

decoder_norm_types: Union[str, Tuple[str]] = "rms_norm",

decoder_act_fns: Union[str, Tuple[str]] = "silu",

encoder_out_shortcut: bool = True,

Copy link

Contributor

@a-r-r-o-w a-r-r-o-w Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting for other reviewers - this change looks safe because previous out_shortcut default was True as well in the encoder

src/diffusers/models/autoencoders/autoencoder_dc.py

decoder_norm_types: Union[str, Tuple[str]] = "rms_norm",

decoder_act_fns: Union[str, Tuple[str]] = "silu",

encoder_out_shortcut: bool = True,

decoder_in_shortcut: bool = True,

Copy link

Contributor

@a-r-r-o-w a-r-r-o-w Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is safe because previous in_shortcut default was True in decoder

@HuggingFaceDocBuilderDev

Copy link

HuggingFaceDocBuilderDev commented Aug 18, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.