Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(queue): moved socket iteration into queue #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sim-ceridian wants to merge 1 commit into httpswift:stable
base: stable
Choose a base branch
Loading
from sim-ceridian:fix/queue-isolation
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Xcode/Sources/HttpServerIO.swift
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,11 @@ open class HttpServerIO {
public func stop() {
guard self.operating else { return }
self.state = .stopping
// Shutdown connected peers because they can live in 'keep-alive' or 'websocket' loops.
for socket in self.sockets {
socket.close()
}
self.queue.sync {
// Shutdown connected peers because they can live in 'keep-alive' or 'websocket' loops.
for socket in self.sockets {
socket.close()
}
self.sockets.removeAll(keepingCapacity: true)
}
socket.close()
Expand Down
6 changes: 3 additions & 3 deletions Xcode/Tests/FilesTests.swift
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class FilesTests: XCTestCase {
let closure = shareFile(temporaryDirectoryURL.appendingPathComponent("does_not_exist").path)
let result = closure(request)

XCTAssert(result == .notFound)
XCTAssert(result == .notFound())
}

func testShareFilesFromDirectory() {
Expand All @@ -77,7 +77,7 @@ class FilesTests: XCTestCase {
let closure = shareFilesFromDirectory(temporaryDirectoryURL.path)
let result = closure(request)

XCTAssert(result == .notFound)
XCTAssert(result == .notFound())
}

func testDirectoryBrowser() {
Expand All @@ -95,6 +95,6 @@ class FilesTests: XCTestCase {
let closure = directoryBrowser(temporaryDirectoryURL.path)
let result = closure(request)

XCTAssert(result == .notFound)
XCTAssert(result == .notFound())
}
}

AltStyle によって変換されたページ (->オリジナル) /