-
Notifications
You must be signed in to change notification settings - Fork 269
Open
Conversation
MaxSagebaum
commented
Jun 23, 2025
Contributor
Looks good.
hsutter
hsutter
requested changes
Jul 27, 2025
@hsutter
hsutter
left a comment
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have a question about the new parameter...
@hsutter
hsutter
added
the
question - further information requested
Further information is requested
label
Jul 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1397. Function pointers (but not functions) can now be return types.
It turns out that even if we correctly parse a function pointer type, we drop the pc_qualifiers when we generate the C++1 code. So I fixed that too.