-
-
Notifications
You must be signed in to change notification settings - Fork 584
HV-2135 Better leverage the node/path mutability #1696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marko-bekhta
merged 3 commits into
hibernate:main
from
marko-bekhta:fix/HV-2135-WIP-experiments
Sep 2, 2025
Merged
HV-2135 Better leverage the node/path mutability #1696
marko-bekhta
merged 3 commits into
hibernate:main
from
marko-bekhta:fix/HV-2135-WIP-experiments
Sep 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You getting it even faster?
You getting it even faster?
🙈 🫣 I was trying to figure out why the predefined scope case can still be slower then the regular case... and while at it found these few things. But still unsure what's causing the occasional slowdown 😕
Current patch:
Benchmark Mode Cnt Score Error Units
o.h.v.p.cascaded.CascadedWithLotsOfItemsAndCyclesValidation.testCascadedValidationWithLotsOfItems thrpt 15 22475.892 ± 303.829 ops/s
o.h.v.p.cascaded.PredefinedScopeCascadedWithLotsOfItemsAndCyclesValidation.testCascadedValidationWithLotsOfItems thrpt 15 24050.667 ± 524.209 ops/s
o.h.v.p.simple.SimpleSingleElementValidation.invalidObjectValidation thrpt 15 12376.592 ± 102.328 ops/ms
o.h.v.p.simple.SimpleSingleElementValidation.validObjectValidation thrpt 15 53082.121 ± 315.109 ops/ms
9.1.0.Alpha1
Benchmark Mode Cnt Score Error Units
o.h.v.p.cascaded.CascadedWithLotsOfItemsAndCyclesValidation.testCascadedValidationWithLotsOfItems thrpt 20 20107.524 ± 33.186 ops/s
o.h.v.p.cascaded.PredefinedScopeCascadedWithLotsOfItemsAndCyclesValidation.testCascadedValidationWithLotsOfItems thrpt 20 17983.391 ± 28.931 ops/s
o.h.v.p.simple.SimpleSingleElementValidation.invalidObjectValidation thrpt 20 10799.710 ± 24.398 ops/ms
o.h.v.p.simple.SimpleSingleElementValidation.validObjectValidation thrpt 20 34603.538 ± 86.836 ops/ms
9.1.0.Alpha1 (cascading no cycle -- no noticable difference)
o.h.v.p.cascaded.PredefinedScopeCascadedWithLotsOfItemsValidation.testPredefinedScopeCascadedValidationWithLotsOfItems thrpt 20 24261.606 ± 50.214 ops/s
o.h.v.p.cascaded.CascadedWithLotsOfItemsValidation.testCascadedValidationWithLotsOfItems thrpt 20 24203.927 ± 40.968 ops/s
9.0
Benchmark Mode Cnt Score Error Units
o.h.v.p.cascaded.CascadedWithLotsOfItemsAndCyclesValidation.testCascadedValidationWithLotsOfItems thrpt 15 7475.159 ± 120.414 ops/s
o.h.v.p.cascaded.PredefinedScopeCascadedWithLotsOfItemsAndCyclesValidation.testCascadedValidationWithLotsOfItems thrpt 15 7506.502 ± 89.779 ops/s
o.h.v.p.simple.SimpleSingleElementValidation.invalidObjectValidation thrpt 15 6647.196 ± 72.001 ops/ms
o.h.v.p.simple.SimpleSingleElementValidation.validObjectValidation thrpt 15 17785.621 ± 583.771 ops/ms
Signed-off-by: marko-bekhta <marko.prykladna@gmail.com>
...r elements Signed-off-by: marko-bekhta <marko.prykladna@gmail.com>
@marko-bekhta
marko-bekhta
force-pushed
the
fix/HV-2135-WIP-experiments
branch
from
September 2, 2025 10:45
d936865 to
e7bb1d1
Compare
Quality Gate Passed Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
99.1% Coverage on New Code
1.1% Duplication on New Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HV-2135
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on licensing, please check here.