-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
encapsulate EntityMetamodel within AbstractEntityPersister #10856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eventually this will be a switch (pattern match)
first step toward removing EntityMetamodel, as promised since 6.0
second step toward removing EntityMetamodel, as promised since 6.0
Thanks for your pull request!
This pull request does not follow the contribution rules. Could you have a look?
❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
↳ Offending commits: [b02eabf, 8fa81aa, 1dfba53, 6be5d50, ee55d2e, c28c1ef, 3867983, a795f3b, 563093a]
› This message was automatically generated.
Check notice
Code scanning / CodeQL
Possible confusion of local and field Note
EntityMetamodel
Uh oh!
There was an error while loading. Please reload this page.
lazy
Uh oh!
There was an error while loading. Please reload this page.
I guess I'm going to go ahead and merge these changes, even though @sebersole has not yet given his opinion, because otherwise I'm just going to get a mess of conflicts with other work.
The two very important commits here are easy enough to roll back of Steve hates them or has a better idea. (Most of the commits on this PR are included here only to avoid conflicts.)
EntityMetamodelhas been deprecated for removal since 6.0.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.