-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-18686 - align behaviour of SchemaTool and SchemaExportTask with respect to ordering columns and metadata validation #10843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see a need to allow parameterizing the forceOrderColumns flag. This flag is only useful if the Metadata object is reused for multiple schema export tasks, which it isn't here. IMO, the flag is usually only useful for tests to avoid redoing boot model building when testing multiple scenarios.
...espect to ordering columns and metadata validation Signed-off-by: Jan Schatteman <jschatte@redhat.com>
@jrenaat
jrenaat
force-pushed
the
HHH-18686_schemaexport
branch
from
August 29, 2025 14:36
3862fb3 to
05f7d78
Compare
beikov
beikov
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-18686