-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19723 Upgrade from wildfly-transaction-client-jakarta 2.x to wildfly-transaction-client 3.x in hibernate-testing #10797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request!
This pull request appears to follow the contribution rules.
› This message was automatically generated.
c3c00ae to
75252e1
Compare
I will upgrade the dependency instead of removing it.
Removing it causes issues, because tests start using JBossStandAloneJtaPlatform all of a sudden, and that makes some tests related to classloading leaks fail.
I'll ask around whether this JBossStandAloneJtaPlatform shouldn't just be removed, because it does seem obsolete to me.
In the meantime, upgrading should work fine.
...fly-transaction-client 3.x in hibernate-testing
75252e1 to
a14adad
Compare
Uh oh!
There was an error while loading. Please reload this page.
https://hibernate.atlassian.net/browse/HHH-19723
It compiles locally, now let's see if tests pass or if there is some surprise...
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.