-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19716 Set the collection owner when wrapping a collection into a persistent one #10778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hibernate-core/src/main/java/org/hibernate/internal/StatelessSessionImpl.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/internal/StatelessSessionImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want the owner to be non-null after a remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that ... idk 🤷🏻 🙂
wouldn't we want to know to what the collection belonged to before it was removed?
My thinking is that event.getAffectedOwnerOrNull() == event.getCollection().getOwner()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're sure this is pre-existing behavior and we don't need to change it to fix the bug, fine by me.
2ef4bdd to
23f9fac
Compare
https://hibernate.atlassian.net/browse/HHH-19716
It doesn't look like
wrap()is called by Reactive directly, so it seems safe to update the method, no?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.