-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19733 Some small tweaks to the Bytecode Enhancer #10771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request!
This pull request appears to follow the contribution rules.
› This message was automatically generated.
6b0566d to
551c73f
Compare
551c73f to
b199944
Compare
I think it's ready now - or, more accurately, that I should stop :)
b199944 to
498ff74
Compare
498ff74 to
d15a0dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT, looks good to me. Bonus points if you change the new/extracted classes to records ;)
AFAICT, looks good to me. Bonus points if you change the new/extracted classes to records ;)
ah, I might do it as a lazy follow-up.. but why, what would the benefit be?
Uh oh!
There was an error while loading. Please reload this page.
HHH-19733
We're exploring (@gsmet and me) how to make the enhancer faster - these fixes here are NOT the main bottleneck, but it's useful to get this "noise" out of the profiling data - and they help.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19733