Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat!: remove deprecated backup window flag#710

Draft
phm07 wants to merge 1 commit intomain from
remove-backup-window
Draft

feat!: remove deprecated backup window flag #710
phm07 wants to merge 1 commit intomain from
remove-backup-window

Conversation

@phm07
Copy link
Contributor

@phm07 phm07 commented Mar 7, 2024

This flag has been deprecated (and not working) since 2018: #147

@phm07 phm07 self-assigned this Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.14%. Comparing base (f2fb321) to head (2bddf46).
Report is 126 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@
## main #710 +/- ##
==========================================
- Coverage 60.14% 60.14% -0.01% 
==========================================
 Files 191 191 
 Lines 6808 6802 -6 
==========================================
- Hits 4095 4091 -4 
+ Misses 2099 2098 -1 
+ Partials 614 613 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jooola jooola changed the title (削除) fix: remove deprecated backup window flag (削除ここまで) (追記) feat: remove deprecated backup window flag (追記ここまで) Mar 7, 2024
@apricote apricote changed the title (削除) feat: remove deprecated backup window flag (削除ここまで) (追記) feat!: remove deprecated backup window flag (追記ここまで) Mar 8, 2024
@apricote apricote added this to the v2 milestone Mar 12, 2024
Copy link
Member

This is a potentially breaking change. Even though this flag shows a warning since 2018, we should try to avoid making breaking changes on purpose.

I have created a v2 milestone and added this PR to it, so we have a list of things to tackle if we decide to work on it.

@phm07 phm07 force-pushed the remove-backup-window branch from ca3dfd3 to 2bddf46 Compare May 23, 2024 12:45
Copy link
Contributor

This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs.

Copy link
Contributor

This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

Projects

None yet

Milestone

v2

Development

Successfully merging this pull request may close these issues.

Comments

AltStyle によって変換されたページ (->オリジナル) /