Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add js-checks-pnpm workflow #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gndelia wants to merge 2 commits into main
base: main
Choose a base branch
Loading
from add-js-checks-with-pnpm
Open

Add js-checks-pnpm workflow #12

gndelia wants to merge 2 commits into main from add-js-checks-with-pnpm

Conversation

@gndelia
Copy link
Contributor

@gndelia gndelia commented Jan 23, 2026

Follow-up of hemilabs/actions#29

This PR adds a workflow that is based on js-checks but uses pnpm.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new reusable GitHub Actions workflow for running JavaScript checks using pnpm as the package manager, as opposed to the existing js-checks workflow that uses npm.

Changes:

  • Created js-checks-pnpm.yml workflow with two jobs: run-checks and run-tests
  • Added configurable inputs for fetch depth and Node.js version matrix testing
  • Implemented pnpm-based commands for formatting, linting, dependency checks, building, and testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@gabmontes gabmontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reusable actions and workflows should go to hemilabs/actions. What is preventing to have this file there instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@joshuasing joshuasing joshuasing approved these changes

@arielmergen arielmergen Awaiting requested review from arielmergen

@ArturDolzan ArturDolzan Awaiting requested review from ArturDolzan

@gabmontes gabmontes Awaiting requested review from gabmontes

At least 2 approving reviews are required to merge this pull request.

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /