Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix warning for -Werror build in Circle CI #4727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into haskell:master from fendor:fix/sig-help-docs-wall
Sep 15, 2025

Conversation

Copy link
Collaborator

@fendor fendor commented Sep 15, 2025
edited
Loading

Circle CI runs its builds with -Werror. Thus, we need to fix the warning that was accidentally introduced.

See for example the logs of the job https://circleci.com/gh/haskell/haskell-language-server/70398 in #4726

@fendor fendor added the merge me Label to trigger pull request merge label Sep 15, 2025
@mergify mergify bot merged commit 808407b into haskell:master Sep 15, 2025
48 of 51 checks passed
import Control.Exception (throw)
import Control.Lens ((^.))
import Data.Maybe (fromJust)
import Data.String.Interpolate (__i)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and sorry for the extra work.


I am aware that this import line is redundant after #4717 is merged. However, I am surprised that this causes CI failures since the circleci check did pass before I merged #4626.

I have done some digging and found the cause. The default behavior of GitHub's actions/checkout is merging the PR branch and the target branch. On the contrary, the default behavior of circleci's checkout does not do the merge. Both of them can be configured to change to another behavior. Here is GitHub's doc. I do not find the doc of circleci, but it should be doable.

It is debatable whether we should do the merge in the checkout action or not. However, having different behaviors in different CI checks is just wrong, I think. We should choose one single checkout behavior for all CI checks.

related: https://www.github.com/actions/checkout/issues/504

fendor reacted with thumbs up emoji
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to migrate away from CircleCI as there is no reason to have CircleCI and GHA. The main issue so far was that we are limited by our caches, we only have 10GB, and our current jobs fill this quota by far. In fact, we are usually not hitting caches for at least one job because they were already evicted.
In the release CI, there is a cabal-cache process that backs up CI artefacts to a s3 buckets, perhaps we want to do something similar for regular CI jobs. We can't use the same existing s3 buckets, as we are only borrowing them.

soulomoon pushed a commit to soulomoon/haskell-language-server that referenced this pull request Sep 20, 2025
* Fix typo in hls-signature-help-plugin
* Remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jian-lin jian-lin jian-lin left review comments

@dschrempf dschrempf dschrempf approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /