Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

4718 hls graph session restart kills threads belong to later sesion session #4719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
soulomoon wants to merge 1 commit into haskell:master
base: master
Choose a base branch
Loading
from soulomoon:4718-hls-graph-session-restart-kills-threads-belong-to-later-sesion-session

Conversation

Copy link
Collaborator

@soulomoon soulomoon commented Aug 31, 2025 •
edited
Loading

WordAround #4718

Fix the two problems that make hlint plugin flaky

  1. uninterruptibleMask_ to avoid argsSettings capture async exception
  2. bracket around runWithSignal to avoid sending the start signal without end signal, which would make hlint's tests flasky

@soulomoon soulomoon added the performance Issues about memory consumption, responsiveness, etc. label Aug 31, 2025
@soulomoon soulomoon force-pushed the 4718-hls-graph-session-restart-kills-threads-belong-to-later-sesion-session branch 3 times, most recently from 3337d35 to 61cf5e4 Compare September 1, 2025 16:21
@soulomoon soulomoon force-pushed the 4718-hls-graph-session-restart-kills-threads-belong-to-later-sesion-session branch from 61cf5e4 to 315dc7a Compare September 6, 2025 15:35
@soulomoon soulomoon marked this pull request as ready for review September 6, 2025 15:39
@soulomoon soulomoon added flaky test and removed performance Issues about memory consumption, responsiveness, etc. labels Sep 6, 2025
@soulomoon soulomoon marked this pull request as draft September 6, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiemundo eddiemundo Awaiting requested review from eddiemundo eddiemundo is a code owner

@wz1000 wz1000 Awaiting requested review from wz1000 wz1000 is a code owner

@fendor fendor Awaiting requested review from fendor

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hls-graph: thread belong to later session killed by previous session restart
1 participant

AltStyle によって変換されたページ (->オリジナル) /