Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add code action to introduce _ in numeric literals #4716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crtschin wants to merge 6 commits into haskell:master
base: master
Choose a base branch
Loading
from crtschin:crtschin/numeric-underscores-conversions

Conversation

Copy link
Contributor

@crtschin crtschin commented Aug 30, 2025

Closes #4650

This ended up being a bigger change than I intended. Some notes:

  • I followed the groupings in the linked issue per format.
  • I removed the regex-based approach for matching formats for simple string-matching. I didn't quite see an easy way to reuse it, as underscores can appear in any position in a literal. Makes it so we get the "fixing" functionality for semi-free.
    • I did reuse the regex's in the tests.
  • NumericUnderscores is another extension, now the code action can add multiple of these.

fendor reacted with rocket emoji
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution, this looks great to me!

Waiting for another review by @drsooch who is the maintainer of this plugin :)

Co-authored-by: fendor <fendor@users.noreply.github.com>
@fendor fendor added the status: needs review This PR is ready for review label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@drsooch drsooch Awaiting requested review from drsooch drsooch is a code owner

Assignees
No one assigned
Labels
status: needs review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add code action to introduce _ in number literals
2 participants

AltStyle によって変換されたページ (->オリジナル) /