Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

replace usages of NormalizedFilePath with NormalizedUri wherever possible #4622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MangoIV wants to merge 1 commit into haskell:master
base: master
Choose a base branch
Loading
from MangoIV:mangoiv/uri

Conversation

Copy link
Contributor

@MangoIV MangoIV commented Jun 8, 2025

This is useful for being to run haskell-language-server against URIs that are not file URIs.

I am not sure about all the places and there's one more change that I will probably have to do to run HLS over websocket.

soulomoon and ahndmal reacted with rocket emoji
@MangoIV MangoIV changed the title (削除) [feat] replace usages of NormalizedFilePath with NormalizedUri wherever possible (削除ここまで) (追記) [featURE] replace usages of NormalizedFilePath with NormalizedUri wherever possible (追記ここまで) Jun 8, 2025
Copy link
Contributor Author

MangoIV commented Jun 12, 2025

oh no already three conflicts 😭

@MangoIV MangoIV force-pushed the mangoiv/uri branch 2 times, most recently from 5552c2f to 26c5db8 Compare July 15, 2025 20:38
@MangoIV MangoIV changed the title (削除) [featURE] replace usages of NormalizedFilePath with NormalizedUri wherever possible (削除ここまで) (追記) replace usages of NormalizedFilePath with NormalizedUri wherever possible (追記ここまで) Jul 15, 2025
Copy link
Contributor Author

MangoIV commented Aug 6, 2025

oh jeez fixing the testsuite is gonna be real fun :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj Awaiting requested review from michaelpj michaelpj will be requested when the pull request is marked ready for review michaelpj is a code owner

@0rphee 0rphee Awaiting requested review from 0rphee 0rphee will be requested when the pull request is marked ready for review 0rphee is a code owner

@jian-lin jian-lin Awaiting requested review from jian-lin jian-lin will be requested when the pull request is marked ready for review jian-lin is a code owner

@soulomoon soulomoon Awaiting requested review from soulomoon soulomoon will be requested when the pull request is marked ready for review soulomoon is a code owner

@santiweight santiweight Awaiting requested review from santiweight santiweight will be requested when the pull request is marked ready for review santiweight is a code owner

@eddiemundo eddiemundo Awaiting requested review from eddiemundo eddiemundo will be requested when the pull request is marked ready for review eddiemundo is a code owner

@joyfulmantis joyfulmantis Awaiting requested review from joyfulmantis joyfulmantis will be requested when the pull request is marked ready for review joyfulmantis is a code owner

@georgefst georgefst Awaiting requested review from georgefst georgefst will be requested when the pull request is marked ready for review georgefst is a code owner

@jvanbruegge jvanbruegge Awaiting requested review from jvanbruegge jvanbruegge will be requested when the pull request is marked ready for review jvanbruegge is a code owner

@July541 July541 Awaiting requested review from July541 July541 will be requested when the pull request is marked ready for review July541 is a code owner

@ozkutuk ozkutuk Awaiting requested review from ozkutuk ozkutuk will be requested when the pull request is marked ready for review ozkutuk is a code owner

@kokobd kokobd Awaiting requested review from kokobd kokobd will be requested when the pull request is marked ready for review kokobd is a code owner

@fendor fendor Awaiting requested review from fendor fendor will be requested when the pull request is marked ready for review fendor is a code owner

@VeryMilkyJoe VeryMilkyJoe Awaiting requested review from VeryMilkyJoe VeryMilkyJoe will be requested when the pull request is marked ready for review VeryMilkyJoe is a code owner

@drsooch drsooch Awaiting requested review from drsooch drsooch will be requested when the pull request is marked ready for review drsooch is a code owner

@wz1000 wz1000 Awaiting requested review from wz1000 wz1000 will be requested when the pull request is marked ready for review wz1000 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant

AltStyle によって変換されたページ (->オリジナル) /