-
-
Notifications
You must be signed in to change notification settings - Fork 406
Local binding hints (WIP) #4610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local binding hints (WIP) #4610
Conversation
Co-authored-by: fendor <fendor@users.noreply.github.com>
Now let and where clause will show binding type in inlay hints
4c79cba to
5eae7ca
Compare
...to local-binding-hints
5eae7ca to
9cde704
Compare
eede0e7 to
84673ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs a better explanation for documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may also be clearer as a three-way enum called localBindingHintsMode with the options NoLocalHints, UseInlayHints, UseCodeLenses.
happy to let others bikeshed this, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sounds good, although I'm somewhat tempted towards a global option for the user preference here.
84673ac to
a2759f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regenerate these
I wonder what to do about inlay hints vs code lenses. As I commented in the other issue, I do think we should prefer them if we can. But maybe we need a consistent approach. e.g. something like:
- a global "preferred in-buffer display mode: inlay hints/code lenses", default inlay-hints
- if it's set to inlay hints then use inlay hints if the client supports it otherwise fall back to code lenses
Out of scope for this PR though.
Give a shout if you need help/want attention on any bit of it in particular!
Give a shout if you need help/want attention on any bit of it in particular!
will do! haven't had a chance to go through the test failures.
Uh oh!
There was an error while loading. Please reload this page.
continuation of #4368.
so far, I've merged in changes in master and updated things so they compile with ghc-9.12.
TODO:
update: this now allows either code lenses or inlay hints for local bindings. as we discussed, I've defaulted this to code lenses, with an optional toggle to flip on inlay hints instead. but the code lenses don't have their tests restored as yet. will reintroduce those tomorrow.