-
-
Notifications
You must be signed in to change notification settings - Fork 406
T4443 followup Restrict Dependency to only include keys in the downward dependency closure #4609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
+77
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@soulomoon
soulomoon
changed the title
(削除) T4443 followup (削除ここまで)
(追記) T4443 followup Restrict Dependency to only include keys in the downward dependency closure. (追記ここまで)
Jun 1, 2025
@soulomoon
soulomoon
added
the
performance
Issues about memory consumption, responsiveness, etc.
label
Jun 1, 2025
@soulomoon
soulomoon
force-pushed
the
T4443-followup
branch
from
June 3, 2025 10:27
c1c9858 to
01e08c9
Compare
...aph and filterDependencyInformationReachable functions
@soulomoon
soulomoon
force-pushed
the
T4443-followup
branch
from
June 3, 2025 10:37
01e08c9 to
1931d4c
Compare
@soulomoon
soulomoon
changed the title
(削除) T4443 followup Restrict Dependency to only include keys in the downward dependency closure. (削除ここまで)
(追記) T4443 followup Restrict Dependency to only include keys in the downward dependency closure. (WIP/ Not ready for review ) (追記ここまで)
Jun 3, 2025
@fendor
fendor
changed the title
(削除) T4443 followup Restrict Dependency to only include keys in the downward dependency closure. (WIP/ Not ready for review ) (削除ここまで)
(追記) T4443 followup Restrict Dependency to only include keys in the downward dependency closure (追記ここまで)
Jun 3, 2025
@soulomoon I turned the PR into a draft, could you mark it ready for review once you are satisfied?
@soulomoon I turned the PR into a draft, could you mark it ready for review once you are satisfied?
Yes, sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
WIP/ Not ready for review
Restrict Dependency to only include keys in the downward dependency closure. As in #4594 (comment)