-
-
Notifications
You must be signed in to change notification settings - Fork 406
Set the XDG_CACHE_HOME for tests #4572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1a34302 to
7df2e36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But ghcide test is not running for this PR, do you know why it is skipped
https://github.com/haskell/haskell-language-server/blob/master/.github/workflows/test.yml#L51
Outdated skip in CI. Gonna fix that!
Test failures all look genuine, so more investigation is required.
3be9351 to
8dcd861
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be causing long-path issues on windows.
I am unsure how relevant this still is... Anybody an idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a test cabal project, it seems we always create separate .hi/.hie files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But not, if there are multiple "main" scripts:
image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unfortunately a case we have to support, so this change can't be applied as is.
7729e73 to
a7ad2c6
Compare
This makes sure each test run is independent. Makes the tests * iface-error-test-1 * iface-th-test less flaky locally. Should not have any effect on the CI flakiness issue. --- Fix test cases to work with the temporary `XDG_CACHE_HOME` Some tests were launching additional HLS instances for the tests. Fixed, which should make the test slightly faster.
Ghcide test infrastructure was refactored to depend on `hls-test-utils`.
bb55dd7 to
b27f3d2
Compare
Is it blocking by the long path issue for windows? Can we shrink the test cache dir path?
@soulomoon Yes, it is blocking :(
I have no idea how to further shrink down the test cache dir path, without either reimplementing createTemporaryDirectory, or mangling test-case names.
I am further confused why this even is an issue, as the CI runners allegedly enable long file paths.
That seems to be ghc's issue ? see https://gitlab.haskell.org/ghc/ghc/-/issues/13373 @fendor
So to workaround this, we might have to customize our createTemporaryDirectory ?
I am not sure if the issue is still relevant
Uh oh!
There was an error while loading. Please reload this page.
This makes sure each test run is independent.
Makes the tests
less flaky locally. On my machine, these tests were consistently failing after the first successful execution (due to caching the
hiedbafaict.)Should not have any effect on the CI flakiness issue.