-
Notifications
You must be signed in to change notification settings - Fork 38
Comments
Expose combineAlways and hasLeadingPathSeparator#97
Open
hasufell wants to merge 2 commits intohaskell:1.5.0.0 from
Open
Expose combineAlways and hasLeadingPathSeparator #97hasufell wants to merge 2 commits intohaskell:1.5.0.0 from
combineAlways and hasLeadingPathSeparator #97hasufell wants to merge 2 commits intohaskell:1.5.0.0 from
Conversation
@hasufell
hasufell
force-pushed
the
API-extension
branch
from
December 3, 2021 17:08
94ce707 to
80157ac
Compare
Member
Author
hasufell
commented
Dec 3, 2021
Note this behavior:
-- > Posix: "home" <\> "/bob" == "home//bob"
hasufell
hasufell
commented
Dec 3, 2021
Comment on lines
+636
to
+638
if hasLeadingPathSeparator x && not (isDrive x)
then let x' = dropWhile isPathSeparator x
in if null x' then [last x] else x'
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too sure about this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant: #49