-
Notifications
You must be signed in to change notification settings - Fork 38
Comments
Conversation
8106870 to
f88c411
Compare
f88c411 to
2070f3d
Compare
hasufell
commented
Mar 6, 2025
@joeyh can you test this?
hasufell
commented
Mar 6, 2025
The amount of code inlining here is outrageous.
Maybe we need to implement this function somewhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At line 1507 we checked whether WINDOWS is defined, presumably in our branch it isn't so is there any need to consider mingw32 platform here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this function will only be visible in the System.OsPath module for the current platform. It will not be present in either System.OsPath.Posix nor System.OsPath.Windows.
Still it seems in such case it may be permissible for filepath to depend on the Win32 package and reuse its environment handling functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Win32 already depends on filepath, so we can't.
That's why I'm opting for haskell/directory#198
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like sometimes it's checked as #ifdef WINDOWS and other times the check looks like #if defined(WINDOWS). I suggest to unify everything to #if defined(WINDOWS) style.
Fixes #249