Fix write-back rules for Set toList #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

treeowl wants to merge 1 commit into haskell:master

from treeowl:write-back-set

Draft

Fix write-back rules for Set toList #602

treeowl wants to merge 1 commit into haskell:master from treeowl:write-back-set

Conversation

treeowl

Copy link

Contributor

@treeowl treeowl commented Feb 1, 2019

Thanks to GHC Trac ticket 16261, matching on [] in a rule
LHS is pretty dicy. Generalize the write-back rules so we
don't have to.
NOINLINE set-to-list conversions generally when fusion doesn't
happen. Inlining these functions seems rather unlikely to be
productive in general.

@treeowl


 Fix write-back rules for Set toList

31c72ac

* Thanks to GHC Trac ticket 16261, matching on `[]` in a rule
 LHS is pretty dicy. Generalize the write-back rules so we
 don't have to.
* `NOINLINE` set-to-list conversions generally when fusion doesn't
 happen. Inlining these functions seems rather unlikely to be
 productive in general.

@m-renaud

Copy link

Contributor

m-renaud commented Feb 1, 2019 •

edited

Loading

(削除) Note that as of 7 hours ago the ticket was updated and the reporter inadvertently had the overloaded lists extension enabled. Do, this appears to perennially not be an issue (?) unless I'm reading it wrong. (削除ここまで)