-
Notifications
You must be signed in to change notification settings - Fork 34
ghcjs buildable version #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: buckie <wjm@Williams-MacBook-Pro.local>
Signed-off-by: buckie <wjmartino@gmail.com>
Signed-off-by: buckie <wjmartino@gmail.com>
Signed-off-by: buckie <wjmartino@gmail.com>
Signed-off-by: buckie <wjmartino@gmail.com>
Signed-off-by: buckie <wjmartino@gmail.com>
Signed-off-by: buckie <wjmartino@gmail.com>
Collaborator
erikd
commented
Oct 23, 2016
@buckie Your PR doesn't build with ghc 7.6 of ghc 7.8:
src/Data/Thyme/Clock/TAI.hs:85:52:
Not in scope: ‘mempty’
Versions of GHC earlier than 7.10 did not include Data.Monoid in the standard prelude. Fixing this probably involves adding something like:
#if __GLASGOW_HASKELL__ < 710
import Data.Monoid (mappend)
#endif
...lens flag Signed-off-by: buckie <wjmartino@gmail.com>
@buckie
buckie
force-pushed
the
feat/ghcjs-buildable
branch
from
October 23, 2016 17:56
a3b56e3 to
142fbf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big fan of the library, including the api upgrades from 0.3.5.5. I needed to build this via ghcjs and
cpphsorthyme.hwas blowing it up (linker errors, couldn't figure out which one). Regardless, this version built fine on OSX for ghcjs at the cost of thelensflag. Overall I dislike having a little custom lens as more and more people start using this lib but I do see the motivation as the build times increase. I think givenstackandnew-buildthat one time build hit is no longer so onerous.