-
Notifications
You must be signed in to change notification settings - Fork 666
Comments
FIX: Some hardware ID are not compatible with ascii, in that case fal...#2001
Open
prunith wants to merge 4 commits intohardbyte:main from
Open
FIX: Some hardware ID are not compatible with ascii, in that case fal... #2001prunith wants to merge 4 commits intohardbyte:main from
prunith wants to merge 4 commits intohardbyte:main from
Conversation
Collaborator
zariiii9003
commented
Nov 30, 2025
Please add a short news fragment, so i can merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...lback to guid
Summary of Changes
This change correct detection of hardware id for legacy product and VCI 3.5 (i.e {xxxxxx-xxxx-xxxx-xxxxxxxxxxxx}). decode("ascii") is not able to produce a result and trig an exception.
For this particular situation we use AsGuid and compute string {xxxxxx-xxxx-xxxx-xxxxxxxxxxxx} the same that is reported by iXXat cananalizer. Also update config hwid detection.
Related Issues / Pull Requests
Not linked to Issue yet
Type of Change
Checklist
tox).Additional Notes