-
Notifications
You must be signed in to change notification settings - Fork 666
Apply asc format since format v8.1#1641
Apply asc format since format v8.1 #1641Tian-Jionglu wants to merge 6 commits intohardbyte:main from
Conversation
zariiii9003
commented
Aug 24, 2023
@Tian-Jionglu Are you still working on the tests? I cannot merge if the tests are failing.
can/io/asc.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider parsing the version using our existing dependency packaging.
Tian-Jionglu
commented
Nov 1, 2023
Commits to parse the ASC format version using packaging.
Jobs in working: change ASC format test to adjust absolute time.
zariiii9003
commented
Dec 1, 2023
The ASC tests are still failing.
Tian-Jionglu
commented
Dec 3, 2023
When diving into test example, i found my mistake at the start.
The symbolic name issue is not only related to ASC format version. In fact, SymblicName works for symbolic logging at first place.
I'm still looking for example about symblic logging.
I would close this PR in coming days, and start a new PR to inherit the change to fix absolute time in ASC format.
If there is already support about symbolic logging in python-can, please give me a hint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the files can contain multiple triggers. Parsing it as part of the header is probably not sufficient.
Tian-Jionglu
commented
Jun 11, 2024
see PR #1788
A solution to solve issue #1531.
Mainly include 2 changes in
ASCReaderclass:start_time,version,date, etc before iterate the messages. I think this is necessary;_process_fd_can_frame_2to process CANFD message in ASCFormat since V8.1;Remaining issue:
some tests can not pass, mainly because after the change, correct
absolutetimestamp is get when iterate the messages;