-
Notifications
You must be signed in to change notification settings - Fork 666
Fix IXXAT periodic messages not working#1628
Merged
zariiii9003 merged 1 commit intohardbyte:release-4.2 from Jul 7, 2023
ChargedByte:fix_ixxat_periodic
Merged
Fix IXXAT periodic messages not working #1628zariiii9003 merged 1 commit intohardbyte:release-4.2 from ChargedByte:fix_ixxat_periodic
zariiii9003 merged 1 commit intohardbyte:release-4.2 from
ChargedByte:fix_ixxat_periodic
Conversation
Collaborator
zariiii9003
commented
Jul 6, 2023
This change makes IXXATbus use thread based periodic tasks instead the hardware based implementations. I think it better than nothing, but it's not really fixing the issue.
I hope #1611 will fix all issues.
Author
ChargedByte
commented
Jul 6, 2023
Ah, that makes sense. Looks like I didn't do enough research into the library, sorry about that. The workaround works for us and we can keep applying it locally. Probably best to close this PR and just wait for the refactoring?
Collaborator
zariiii9003
commented
Jul 7, 2023
I'll merge this. Thread-based periodic tasks are better than exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
As reported in a few instances, the periodic messages don't work on IXXAT. The
IXXATBusappears to be just missing the call to the super-classes constructor. This call is present in thedevelopbranch but is missing in the current release v4.2.2References: #1285 #1605