-
Notifications
You must be signed in to change notification settings - Fork 666
Comments
Fix inefficiencies, causes write delays to drop#1572
Draft
silverv wants to merge 2 commits intohardbyte:main from
Draft
Fix inefficiencies, causes write delays to drop #1572silverv wants to merge 2 commits intohardbyte:main from
silverv wants to merge 2 commits intohardbyte:main from
Conversation
Author
silverv
commented
Apr 21, 2023
On Windows it is important to note that a REALTIME priority level can be assigned to the process.
Author
silverv
commented
Apr 21, 2023
This is a continuation of #1490
Author
silverv
commented
Apr 21, 2023
I am doing this to improve the performance of SLCAN in Yakut (https://github.com/OpenCyphal/yakut) and Yukon (https://github.com/OpenCyphal/yukon).
Collaborator
zariiii9003
commented
Apr 23, 2023
With your changes the timeout parameter will do nothing.
Also, your title mentions write delays, but you change the read function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did some experiments and measurements to conclude that these changes introduce less write delay. It is also likely that CPU load will be decreased with these changes.