Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add support for modal vm runtime#1907

Open
shariqm-modal wants to merge 1 commit into
harbor-framework:main from
modal-projects:shariqm-modal/modal-vm-runtime
Open

add support for modal vm runtime #1907
shariqm-modal wants to merge 1 commit into
harbor-framework:main from
modal-projects:shariqm-modal/modal-vm-runtime

Conversation

@shariqm-modal

@shariqm-modal shariqm-modal commented Jun 13, 2026
edited by devin-ai-integration Bot
Loading

Copy link
Copy Markdown

Modal recently alpha released VM Sandboxes, and Harbor users have asked for support. This PR adds an opt-in path for Modal environments via --environment-kwarg modal_vm_runtime=true.

  • Adds Modal VM runtime opt-in through environment kwargs (modal_vm_runtime).
  • Enforces VM runtime GPU incompatibility with a clear error.
  • Adjusts memory handling for VM runtime so request/limit semantics align with Modal VM behavior (e.g. LIMIT mode resolves to equal request and limit).
  • Keeps existing DinD behavior for non-VM mode (enable_docker=True), while using VM runtime options when modal_vm_runtime=true.

Try it out:
uv run harbor run -t hello-world/hello-world --env modal --ek modal_vm_runtime=true


Open in Devin Review

vercel Bot commented Jun 13, 2026

Copy link
Copy Markdown

@shariqm-modal is attempting to deploy a commit to the Harbor Framework Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Contributor

Enjoy a better diff viewing experience by clicking one of these URLs:

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Open in Devin Review

Comment thread src/harbor/environments/modal.py
Comment thread src/harbor/environments/modal.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /