-
Notifications
You must be signed in to change notification settings - Fork 313
Allow WebP transparency #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
coveralls
commented
Feb 21, 2019
Pull Request Test Coverage Report for Build 204
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 204
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any test case about this webp transparency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, here you are : https://we.tl/t-KAjNhXovT6
The original png + the webp generated with the code modified above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wearemetabolism, thank you for your reply.
Could you write some test cases with PHPUnit on this PR?
I don't think it's a proper way to provide the project archive about this test I mention...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @peter279k sure, I've added some test, I don't understand why travis failed.
Tests are ok by my side : OK (42 tests, 76 assertions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wearemetabolism, thank you for your reply.
It looks strange after tracing the Travis CI build.
I will take a look at this log clearly.
BTW, could you rebase the commits to one commit? And we can looks the changes easily.
This is still failing. It should pass before we merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to the clover.xml under the Git version control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep I think we should has the build folder in the gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Travis CI build is failed because the configure file is not found.
It seems that you want to compile the PHP with gd extension again.
The configure file should be in the php-src folder and I don't think this folder will be existed in this current working directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, yes I was trying to understand how to enable webp support
Hi there, after spending some times to understand the problem, it seems that Travis do not compile php with webp support, I didn't figured out how to reconfigure php to support it, tests failed because until now there wasn't any test about webp...
The last test failed because it could not find .configure.
No description provided.