-
-
Notifications
You must be signed in to change notification settings - Fork 43
config modification #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config modification #131
Conversation
@ghost
ghost
commented
Oct 29, 2020
- Plugins : isProd seems occuring error
- Color mode change
- navbar parameter naming
- Footer title miss
Deploy website version based on 91d3a05
Deploy website version based on f719e07
Deploy website version based on f719e07
Deploy website version based on 028b765
Deploy website version based on 028b765
Deploy website version based on d943b2f
Deploy website version based on 59416de
Deploy website version based on d609cea
Deploy website version based on d609cea
Deploy website version based on 229f0a3
Deploy website version based on 2aec0ff
Deploy website version based on 2aec0ff
Deploy website version based on e47d922
Deploy website version based on 033070c
Deploy website version based on b27bbb7
Deploy website version based on 15e5c01
Deploy website version based on 15e5c01
Deploy website version based on 946573d
Deploy website version based on 2e99cea
Deploy website version based on 839d4e0
Deploy website version based on 7060cf2
Deploy website version based on dd1385c
1. Plugins : isProd seems occuring error 2. Color mode change 3. navbar parameter naming 4. Footer title miss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donghwipark when you change all the ' to ", I can't tell which changes actually matter. Can you please switch those back to '?
Oh it seems I accidently changed through prettier. Will change to " to ' and mention here which code I changed manually.
I changed to single quote and seem you can check in fils changed exactly which has modified please confirm. 👍
https://github.com/gulpjs/gulpjs.github.io/pull/131/files
Thank you for fixing that! I notice that it added commas also, but I'm those should be there anyway. I will review this and make suggestions this weekend.
@donghwipark I just noticed that you have not committed any changes to the package.json and package-lock.json files, which need to be updated for the new version of docusaurus. Did you mistakenly leave out those updates?
It was a mistake, will pull request with package json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donghwipark Sorry it has taken so long to review this. It looks like version alpha.70 has been released since you submitted this PR. Can you please update and apply any changes needed for that new version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version alpha.68 and higher fixed this issue (with facebook/docusaurus#3704), so we can add these back.
@donghwipark it looks like you pulled/merged master instead of the source branch 😬
Yes I accidently pulled the master.. I pull request with another commit please confirm.