Set search input size to 16px #119 #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

phated merged 1 commit into gulpjs:source from dpanov:119

May 3, 2020

Merged

Set search input size to 16px #119 #120

phated merged 1 commit into gulpjs:source from dpanov:119

May 3, 2020

Conversation

dpanov

Copy link

Contributor

@dpanov dpanov commented May 3, 2020

Fixes #119 .

Btw, the docs.css file looks like it could use some refactoring.
Here's some stuff I was thinking of doing:

Change the file to be a SCSS file
Nest media queries inside CSS selectors (e.g. the way it's done in src/theme/BackerSection/backers.module.scss)
Group together the selectors - e.g. we are referencing .navbar__search-input in three different places. It will be easier to maintain if the CSS for the selector is in one place.
Lower the specificity of some selectors - this could be tricky, because 1. Infima has some unnecessary heavy selectors and 2. the CSS bundling is weird and puts the custom CSS (docs.css) somewhere in the middle of the output file and its selectors are being overwritten by other CSS.

If it's OK I can open a separate PR for these?

@dpanov


 Set search input size to 16px #119

4f4df67

Set search input font family to "Poppins";

@phated

Copy link

Member

phated commented May 3, 2020

@dpanov Thank you! I love all of your ideas. Happy to review any PRs that you send for those.

We might also loop in @yangshun and @lex111 if we need anything changed in Docusaurus or Infima (like the specificity).

@phated phated merged commit ccaabb4 into gulpjs:source

May 3, 2020

@lex111

Copy link

In fact, a few months ago, in the Infima repository (it is private), I opened a PR that removes redundant specificity, but so far that PR has not been reviewed, so this is a good reminder for @yangshun.

Labels

None yet

3 participants

@dpanov @phated @lex111

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Set search input size to 16px #119 #120

Set search input size to 16px #119 #120

Uh oh!

Conversation

@dpanov dpanov commented May 3, 2020

Uh oh!

phated commented May 3, 2020

Uh oh!

lex111 commented May 3, 2020

Uh oh!

Uh oh!