Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use Eloquent builder methods instead of scopes #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatanYadaev wants to merge 2 commits into grimzy:master
base: master
Choose a base branch
Loading
from MatanYadaev:scopes-to-builder-methods

Conversation

Copy link
Contributor

@MatanYadaev MatanYadaev commented Nov 5, 2020

This PR moves the whole scopes to a dedicated builder (which already exists).

This approach presented introduced in the "Dedicated query builders for Eloquent models" blogpost.

@grimzy What do you think about this approach? Do you notice any drawbacks?

Personally, in my own company, we're using only dedicated model builders and there's a lot of benefit from it.
I thought it could be great to have real IDE autocomplete for spatial methods:

namespace App\Builders;
use Grimzy\LaravelMysqlSpatial\Eloquent\Builder as SpatialBuilder;
use Grimzy\LaravelMysqlSpatial\Types\Point;
class UserBuilder extends SpatialBuilder
{
 public function inRange(Point $point, int $radius)
 {
 $this->distanceSphereValue('location', $point)->having('distance', '<', $radius);
 return $this;
 }
}

hananbo, aryehbeitz, OhadRon, san4io, and krenor reacted with thumbs up emoji
@MatanYadaev MatanYadaev changed the title (削除) Use builder methods instead of scopes (削除ここまで) (追記) Use Eloquent builder methods instead of scopes (追記ここまで) Nov 5, 2020
Copy link
Contributor Author

@grimzy WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /