-
Notifications
You must be signed in to change notification settings - Fork 334
Custom spherical radius & SpatialTrait annotations #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you @khooz !
I've been working on adding SRID support in the srid branch. Would you mind merging from there and change the base of this PR from master to srid?
Also:
Can I change the base of this PR and work on it?
cc: @khooz
Also, feel free to test the srid branch. Tell me how it goes.
Sure. Sorry for the late response. I will test that branch too, though applications may be limited since most of the time, sticking to one SRID (no matter which) will give you a fair result in cases such as distance.
It is adding a parameter for spherical functions for radius, annotates SpatialTrait with PHPDoc blocks, and defaults the earth radius to a more accurate median (down to cm).
It references #91 and #114; it also fails at CI since the more accurate default radius and the nature of new functionality, which I hope can be resolved.