-
-
Notifications
You must be signed in to change notification settings - Fork 143
Cache node hashing #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Cache node hashing #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks, will check this out. One minor disadvantage ist that when you modify the AST, then you must also reset the cashed hash value. Or maybe we should do it automatically in the __setattr__ method?
Good idea. I get about the same results with an added __setattr__ override that resets _hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds basic caching for
Node.__hash__. The primary goal of this change is to optimize validation. The benchmark I tested against istests/benchmarks/test_validation_gql.py.Locally, this benchmark goes from
7msto4mswith this change. I've also done some testing against an internal schema from our application, using a large query from our application instead of the introspection query. In that test, validation time dropped from28msto11mslocally.