-
Notifications
You must be signed in to change notification settings - Fork 1.1k
handle case insensitive array inputs in query #6075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shiyasmohd
merged 2 commits into
master
from
shiyasmohd/fix-array-case-insensitive-query-input
Aug 26, 2025
Merged
handle case insensitive array inputs in query #6075
shiyasmohd
merged 2 commits into
master
from
shiyasmohd/fix-array-case-insensitive-query-input
Aug 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good, but we should also add a test in store/test-store/tests/graphql/query.rs
that checks that this works properly. You can probably use the Musician.bands
field for that
@shiyasmohd
shiyasmohd
force-pushed
the
shiyasmohd/fix-array-case-insensitive-query-input
branch
from
August 22, 2025 04:20
d5e8977
to
c7cb99a
Compare
@lutter added the test case.
lutter
lutter
approved these changes
Aug 26, 2025
@shiyasmohd
shiyasmohd
deleted the
shiyasmohd/fix-array-case-insensitive-query-input
branch
August 26, 2025 16:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5828