Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: implement Indexing Agreements [Pending Audit] #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matiasedgeandnode wants to merge 1 commit into tmigone/horizon-fixes-june
base: tmigone/horizon-fixes-june
Choose a base branch
Loading
from ma/indexing-payments-003

Conversation

Copy link
Contributor

@matiasedgeandnode matiasedgeandnode commented Mar 26, 2025 •
edited
Loading

Copy link

openzeppelin-code bot commented Mar 26, 2025 •
edited
Loading

feat: implement Indexing Agreements [Pending Audit]

Generated at commit: a7fb8758ffccad6a6f80dadcc68b12306ac0f615

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
4
0
15
39
60
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Contributor Author

ok, NatSpec added, pnpm lint:sol:natspec reporting same warnings as in horizon

@matiasedgeandnode matiasedgeandnode changed the base branch from horizon to tmigone/horizon-fixes-june June 9, 2025 17:51
Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with two small comments and pending audit)

matiasedgeandnode reacted with thumbs up emoji
@matiasedgeandnode matiasedgeandnode changed the title (削除) feat: implement Indexing Agreements (削除ここまで) (追記) feat: implement Indexing Agreements [Pending Audit] (追記ここまで) Jun 11, 2025
@matiasedgeandnode matiasedgeandnode marked this pull request as ready for review June 11, 2025 15:52
@tmigone tmigone force-pushed the tmigone/horizon-fixes-june branch 2 times, most recently from 639c56d to d89440a Compare June 18, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcarranzav pcarranzav pcarranzav left review comments

@tmigone tmigone tmigone left review comments

@Maikol Maikol Awaiting requested review from Maikol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /