-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
@mizkei
mizkei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コメントしましたので、参考にしていただければと思います
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size 0の場合は特に指定なしでも問題ありません
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed: 33fc2e4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defer cancel は呼び忘れないようにしましょう
https://golang.org/pkg/context/
Failing to call the CancelFunc leaks the child and its children until the parent is canceled or the timer fires.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed: 01f9a44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bufio.NewScanner で os.Stdin を渡しているため、 sc.Scan は標準入力でenterが入力するまでブロックします
そして、下記の箇所でinputのみを待ってしまうために、なにもせず5秒経過したとしても0問正解として終わらず、その後に入力されたひとつ目の入力を受け付けてしまいます
https://github.com/gopherdojo/dojo4/pull/47/files#diff-4d4d5b583e35d4c540d67179051f4406R29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed: ff5211e
uobikiemukot
commented
Dec 26, 2018
レビューありがとうございました。
ちょこっと指摘箇所を修正しました。
Uh oh!
There was an error while loading. Please reload this page.
課題3-1
時間が足りず、最低限のものしかできていません 😿