-
Notifications
You must be signed in to change notification settings - Fork 371
Speed up iOS resolver by 10-15 minutes #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mazkoshak
Mazkoshak
approved these changes
Feb 16, 2022
chkuang-g
chkuang-g
approved these changes
Feb 24, 2022
Thank you for the fix!
I'm putting together a fix for firebase/quickstart-unity#1178. Once that is done, I'll make another release for EDM4U.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CocoaPods has introduced their CDN in 2019 and made it the default source. EDM's iOS resolver explicitly specifies the old source which has become extremely slow. The old source takes 10-15 minutes to clone on our build agents, making iOS builds needlessly slow. Using the CDN allows us to skip this step and start resolving dependencies right away.
This isn't obvious in local development because it only happens once and gets cached in
~/.cocoapods, but disposable build agents have to run it with every single build. Caching the repo is slow because it's around a gigabyte and contains over one million files.Resolves #470.