Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fixes #425 - Disable addition of BoM for the GvhProjectSettings #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chkuang-g merged 1 commit into googlesamples:master from JohannesDeml:disable-utf8-bom
Jan 18, 2022

Conversation

Copy link

@JohannesDeml JohannesDeml commented Jan 11, 2022

See #425
This fixes the problem for git fighting with the BoM.
From the Microsoft documentation:

Remarks

XmlWriter always writes a Byte Order Mark (BOM) to the underlying data stream; however, some streams must not have a BOM. To omit the BOM, create a new XmlWriterSettings object and set the Encoding property to be a new UTF8Encoding object with the Boolean value in the constructor set to false.

@chkuang-g chkuang-g merged commit 7b195b7 into googlesamples:master Jan 18, 2022
Copy link
Author

Thanks a lot for the merge and the quick release of a new version 🙇‍♂️

@googlesamples googlesamples locked and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /