-
Notifications
You must be signed in to change notification settings - Fork 371
Fixing maven repo path separator char #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing maven repo path separator char #421
Conversation
This bug happens only if: - "Patch mainTemplate.gradle" setting is enabled; - You are resolving dependencies on Windows platform; Examples of bad repo path string in mainTemplate.gradle: file:///C:/Work/UnityProject\Assets/GeneratedLocalRepo/Firebase/m2repository This happened because Path.Combine uses "\" as path separator for windows platforms. But gradle actually expects not a regular path but file URI, where "/" must be used as path separator.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
i️ Googlers: Go here for more info.
@googlebot I signed it!
The bug happens only if:
Examples of bad repo path string in mainTemplate.gradle:
file:///C:/Work/UnityProject\Assets/GeneratedLocalRepo/Firebase/m2repository
This happened because Path.Combine uses "" as path separator for
windows platforms. But gradle actually expects not a regular path
but file URI, where "/" must be used as path separator.