Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Disabling update if the module is disabled in the Unity editor; #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chkuang-g merged 1 commit into googlesamples:master from felipegodias:patch-1
Nov 14, 2020
Merged

Disabling update if the module is disabled in the Unity editor; #413

chkuang-g merged 1 commit into googlesamples:master from felipegodias:patch-1
Nov 14, 2020

Conversation

Copy link
Contributor

@felipegodias felipegodias commented Nov 12, 2020

Added this check to avoid un-needed asset database searches on UpdateAssetsWithBuildTargets(EditorUserBuildSettings.activeBuildTarget); This commit solve perfomance issues when working on big projects.

MartinGonzalez reacted with thumbs up emoji
Added this check to avoid un-needed asset database searches on UpdateAssetsWithBuildTargets(EditorUserBuildSettings.activeBuildTarget); This commit solve perfomance issues when working on big projects.
Copy link

google-cla bot commented Nov 12, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

i️ Googlers: Go here for more info.

Copy link
Contributor Author

@googlebot I signed it!

@chkuang-g chkuang-g merged commit cc7b3b6 into googlesamples:master Nov 14, 2020
chkuang-g added a commit that referenced this pull request Nov 20, 2020
- Version 1.2.162 - Nov 19, 2020
* Version Handler - Improved #413 by preventing Version Handler from running
 in static constructor when it is disabled.
* Package Manager Resolver - Remove GPR
Change-Id: I17a2cb7f55afa19021ac0f60b38ac1eff7d71a72
@googlesamples googlesamples locked and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chkuang-g chkuang-g chkuang-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /