-
Notifications
You must be signed in to change notification settings - Fork 371
Fixes #322, Use the raw property value when the enum does not contain this value #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #322, Use the raw property value when the enum does not contain this value #399
Conversation
...s not contain this value
googlebot
commented
Aug 31, 2020
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
i️ Googlers: Go here for more info.
@googlebot I signed it!
googlebot
commented
Sep 1, 2020
CLAs look good, thanks!
i️ Googlers: Go here for more info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the fix.
Just apply the suggested modification and it is good to go.
Co-authored-by: chkuang-g <31869252+chkuang-g@users.noreply.github.com>
Done! Do you need me to squash or will you do it in the merge?
Thank you :)
This fixes #322 where the unity editor will lose its target sdk setting between unity restarts if you have >28 selected in 2019, since unity AndroidSdkVersions enum does not contain values above 28.
I have no idea why the function for getting the enum value is so roundabout in the first place, perhaps someone could inform me of why we have to go through the enum type and the string name when we have the correct value from the beginning? Are we expecting the enum int values to diverge from the string values at some point?
I made minimal impact on the function since I don't understand the purpose of it :)