-
Notifications
You must be signed in to change notification settings - Fork 371
Grand Cleanup of C# Project Files #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
95b0cfc
to
a4801e0
Compare
I've rebased pull request on master branch. Also I've checked everything is working fine after rebase.
46ea826
to
c599ab3
Compare
883eedd
to
5c6f23b
Compare
@Williewill510
Williewill510
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean and how do I protect my data from being shared ???
Hello!
This is outdated pull request that was not reviewed by developers for approx. three years.
If you have an questions about the changes in this PR, please be more specific, which part you are interested in.
If you have questions about library itself, please ask them in "Issues" section.
Regards,
Anton
chrisyarbrough
commented
Mar 16, 2023
I apparently ran into the same issues as you did. When I opened the solution in Rider nothing compiled due to invalid references. I was able to fix them all in the same way you did and wonder why the project authors or most recent contributors didn't run into the same trouble. Is this different between Visual Studio and Rider or are others not using an IDE? I'd like to help clean things up, review or write documentation but it would be great if some of the more experienced maintainers could say something. :)
Hi @chrisyarbrough !
I believe there are few reasons for this
- I don't think that there are a lot of people who really need to recompile this project. Provided binaries are good enough for most of users 😃
- Rider is more strict in term of what's in .scproj files than Visual Studio. But it also not that common - most of developers are using Visual Studio. Maybe we are only two people who was trying to build this using Rider
- The project build pipeline is based on old version of Unity. I don't remember exactly but I think I had to change something to make it compile using newer Unity version - the project just can't be fully built with default configuration with new Unity version.
Also I think that I was not careful enough and probably done too much changes in single PR, that's why this change was never accepted.
Uh oh!
There was an error while loading. Please reload this page.
I've cleaned up C# project files.
What I changed and why:
../
.TargetFrameworkVersion
are set to3.5
for all projects. This fixes build error in Rider,UnityPackageManagerResolverTests
Now if you have required Unity assemblies in
unity_dlls
folder, you will be able to build all projects in Visual Studio or Rider.Hope that make contributing easier!