-
Notifications
You must be signed in to change notification settings - Fork 371
Turning off auto resolution now prevents several methods from running in the background when they should not have been #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...le to be unhooked and will not automatically be assigned via the PlayServicesResolver's static constructor if auto resoltution is turned off in the settings
googlebot
commented
Dec 14, 2018
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
CLA Signed
googlebot
commented
Dec 14, 2018
CLAs look good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request, much appreciated!
I had one minor nit and was wondering whether you could reformat your commit message to follow the typically accepted style e.g https://github.com/erlang/otp/wiki/writing-good-commit-messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this all looks good. However, Firebase and some other plugins rely upon the bundle ID notification to keep other configuration files up to date. So turning off auto-resolution should probably not turn off bundle ID polling. Any chance we could keep this unconditionally enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I observed, the really heavy hitter was the polling for the android ABIs, so long as that doesn't run all the time the bulk majority of the allocations should go away. I'd trust your judgement on this one regarding polling the bundleid, I just removed any events that hooked into editor update tick. Not really sure how I can reformat my commit message, is that possible with Git?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you can reformat your commit message with "git commit --amend", save a new commit message and force push the change to the head of your review repo.
@oddgamesdaniel I've done some reformatting of your commit and commit message but it's pretty much the same. You're also still credited in the commit message.
Methods that used to be hooked into the editor update tick are now able to be unhooked and will not automatically be assigned via the PlayServicesResolver's static constructor if auto resoltution is turned off in the settings. Original: #173 Change-Id: I91f5019f2dec77f9470f38ac8c9fb978a022d7a6
I ended up merging this in e6d3a26
Methods that used to be hooked into the editor update tick are now able to be unhooked and will not automatically be assigned via the PlayServicesResolver's static constructor if auto resolution is turned off in the settings