-
Notifications
You must be signed in to change notification settings - Fork 130
Use the cross-compilation tool to generate arm64 litecov.#91
Open
secnotes wants to merge 1 commit intogoogleprojectzero:master from
Open
Use the cross-compilation tool to generate arm64 litecov. #91secnotes wants to merge 1 commit intogoogleprojectzero:master from
secnotes wants to merge 1 commit intogoogleprojectzero:master from
Conversation
Collaborator
@ifratric
ifratric
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some comments below.
bool operator< (LoadedModule const& lhs, LoadedModule const& rhs);
#ifdef ARM64
#include <asm/ptrace.h>
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed given that we already include sys/ptrace.h from debugger.h. And if it's needed for cross-compiling, will it cause issues when building for Android using the Android NDK?
cmake --build . --config Release
```
#### Cross-compiling for Linux
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Cross-compiling for aarch64 Linux"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR allows us to generate arm64 litecov in an x86 Linux environment using cross-compilation tools. The advantage of using cross-compilation is that you can generate Tinyinst binaries that can be used by Android or other arm64 systems without the need for Android NDK.
Tip: Of course, in this environment, when compiling, we often need to generate a statically linked binary. Therefore, please add the build option
-DCMAKE_EXE_LINKER_FLAGS=-static