Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix design smells#940

Open
AmanDesai10 wants to merge 10 commits into
googlemaps:main from
AmanDesai10:fix-design-smells
Open

Fix design smells #940
AmanDesai10 wants to merge 10 commits into
googlemaps:main from
AmanDesai10:fix-design-smells

Conversation

@AmanDesai10

@AmanDesai10 AmanDesai10 commented Nov 28, 2023

Copy link
Copy Markdown

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #936 🦕

AmanDesai10 and others added 10 commits November 1, 2023 15:40
• Line count of code is done using VSCodeCounter extension
• Code Coverage Report for test cases is generated using inbuilt functionality of IntelliJ with branch coverage Enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willum070 willum070 Awaiting requested review from willum070

At least 1 approving review is required to merge this pull request.

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple Design Smells Present

AltStyle によって変換されたページ (->オリジナル) /