This repository was archived by the owner on Jun 8, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 103
feat: Add support for multiplexed sessions - #1383
Merged
Merged
Conversation
@product-auto-label
product-auto-label
Bot
added
the
size: l
Pull request size is large.
label
May 29, 2025
@product-auto-label
product-auto-label
Bot
added
the
api: spanner
Issues related to the googleapis/python-spanner API.
label
May 29, 2025
@lszinv
lszinv
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 29, 2025
@yoshi-kokoro
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 29, 2025
environ[SessionOptions.ENV_VAR_ENABLE_MULTIPLEXED] = "true"
environ[SessionOptions.ENV_VAR_ENABLE_MULTIPLEXED_FOR_PARTITIONED] = "true"
environ[SessionOptions.ENV_VAR_ENABLE_MULTIPLEXED_FOR_READ_WRITE] = "true"
environ[SessionOptions.ENV_VAR_FORCE_DISABLE_MULTIPLEXED] = "false"
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to force disable multiplexed
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need it at all? Is this environment variable is being completely removed from the scope of the project?
@product-auto-label
product-auto-label
Bot
added
size: xl
Pull request size is extra large.
and removed
size: l
Pull request size is large.
labels
May 30, 2025
...E_MULTIPLEXED_SESSIONS` and add unit tests. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...` exception from `DatabaseSessionManager` and add unit tests. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...essions, add unit tests. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
Signed-off-by: Taylor Curran <taylor.curran@improving.com>
Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...shotBase` and update attributes and tests. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...edundant as transaction ID is set via `_restart_on_unavailable`) Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...to `Client` so that multiplexed are disabled for _all_ databases. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...Database.run_in_transaction` to not use it. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
... cleanup. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...ession manager. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...s from class attributes to instance attributes. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...d `database.session()` Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...s, add TODOs, and make `Session._transaction` default to None. Plus add some `Optional` typing hints. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...hot` to `_SnapshotBase` and update unit tests. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...nsaction`, move to base class, update tests. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...ransactions. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
... checks, add `raises` documentation. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
..., some minor cleanup. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...mit token returned. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...edentials. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...for testing. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...nsert_then_rollback`. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...e class, simplify `_SnapshotBase` tests, remove redundant tests. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...d_insert_then_rollback` and add `build_request_id` helper method, fix `test_snapshot` and `test_transaction` failures. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...d by maintenance thread. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...r `_SnapshotBase`. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
... constants for next step. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
...ew multiplexed behaviour. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
Signed-off-by: Taylor Curran <taylor.curran@improving.com>
@currantw
currantw
changed the title
(削除) feat: Add support for multiplexed sessions - partitioned (削除ここまで)
(追記) feat: Add support for multiplexed sessions (追記ここまで)
Jun 5, 2025
currantw
currantw
commented
Jun 5, 2025
return all_metadata
def build_request_id(client_id, channel_id, nth_request, attempt):
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added helper method to reduce duplication in tests.
Signed-off-by: Taylor Curran <taylor.curran@improving.com>
currantw
currantw
commented
Jun 5, 2025
Comment on lines
+88
to
+93
elif transaction_type is TransactionType.READ_WRITE:
return False
return (
self._getenv(self.ENV_VAR_ENABLE_MULTIPLEXED)
and self._getenv(self.ENV_VAR_ENABLE_MULTIPLEXED_FOR_READ_WRITE)
and self._is_multiplexed_enabled[transaction_type]
)
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read/write transaction are supported here, but are disabled in DatabaseSessionManager. Will be turning that on in the next PR.
currantw
currantw
commented
Jun 5, 2025
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helpers methods. Added to help simply unit tests.
Signed-off-by: Taylor Curran <taylor.curran@improving.com>
@rahul2393
rahul2393
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2025
@yoshi-kokoro
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2025
...multiplexed sessions due to runtime failures. Signed-off-by: Taylor Curran <taylor.curran@improving.com>
Signed-off-by: Taylor Curran <taylor.curran@improving.com>
Signed-off-by: Taylor Curran <taylor.curran@improving.com>
@rahul2393
rahul2393
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 10, 2025
@yoshi-kokoro
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 10, 2025
rahul2393
rahul2393
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
feat: Add support for multiplexed sessions: